Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sync Groups for MR1K4, MR2K4 and MR3K4, Cooling for M4/5/K4 #40

Merged
merged 3 commits into from
May 8, 2024
Merged

Add Sync Groups for MR1K4, MR2K4 and MR3K4, Cooling for M4/5/K4 #40

merged 3 commits into from
May 8, 2024

Conversation

nrwslac
Copy link
Contributor

@nrwslac nrwslac commented Apr 30, 2024 •
edited
Loading

Description

  • Add Sync Groups for MR1K4, MR2K4 and MR3K4.
  • Add Cooling Variables for MR4/5K4

Motivation and Context

How Has This Been Tested?

  • Running on PLC

Where Has This Been Documented?

Screenshots (if appropriate):

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • Code committed with pre-commit (alternatively pre-commit run --all-files)

@nrwslac nrwslac requested a review from tongju12 April 30, 2024 16:22
@tongju12
Copy link
Contributor

tongju12 commented May 8, 2024

LGTM

@tongju12 tongju12 merged commit 53f5e4b into pcdshub:master May 8, 2024
9 checks passed
@nrwslac nrwslac changed the title Add Sync Groups for MR1K4, MR2K4 and MR3K4. Add Sync Groups for MR1K4, MR2K4 and MR3K4, Cooling for M4/5/K4 Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tongju12 tongju12 tongju12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nrwslac @tongju12