Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: include root index.html in --html output #104

Closed
Closed
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions pdoc/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@
help="The directory to output generated HTML/markdown files to "
"(default: ./html for --html).",
)
aa(
"--html-index",
action="store_true",
help="Make a top-level index.html listing all the documented packages."
)
aa(
"--html-no-source",
action="store_true",
Expand Down Expand Up @@ -487,6 +492,25 @@ def docfilter(obj, _filters=args.filter.strip().split(',')):
# Two blank lines between two modules' texts
sys.stdout.write(os.linesep * (1 + 2 * int(module != modules[-1])))

if args.html and args.html_index:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll name the arg whatever you want, but this is the general idea.

# Add the root index.html at the top level.
# The template expects `modules` to be Tuples of (name, docstring).
module_tuples = sorted((module.name, module.docstring)
for module in modules)
index_text = pdoc._render_template('/html.mako',
modules=module_tuples,
**template_config)
index_file = path.join(args.output_dir, 'index.html')
try:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this logic is adapted from write_files. I couldn't use it directly, since it expects a pdoc.Module as input, so I just copy-pasted. I can go back and refactor that to be more DRY if you prefer.

with open(index_file, 'w+', encoding='utf-8') as w:
w.write(index_text)
except Exception:
try:
os.unlink(index_file)
except Exception:
pass
raise


if __name__ == "__main__":
main(parser.parse_args())