-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: include root index.html
in --html
output
#104
Closed
ryangalamb
wants to merge
6
commits into
pdoc3:master
from
ryangalamb:rjmill/implement-static-html-index
Closed
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d47ccaf
ENH: include root index.html in `--html` output
ryangalamb b422e9a
TST: revert special 'index.html' cases for --html
ryangalamb a7473ca
ENH: `--html-index` for adding top-level index.html
ryangalamb 61662be
TST: test `--html-index` option
ryangalamb 2d3240d
ENH: teach top-level index.html to respect --force
ryangalamb 982f196
ENH: breadcrumbs for modules when `--html-index` is active
ryangalamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82,6 +82,11 @@ | |
help="The directory to output generated HTML/markdown files to " | ||
"(default: ./html for --html).", | ||
) | ||
aa( | ||
"--html-index", | ||
action="store_true", | ||
help="Make a top-level index.html listing all the documented packages." | ||
) | ||
aa( | ||
"--html-no-source", | ||
action="store_true", | ||
|
@@ -487,6 +492,25 @@ def docfilter(obj, _filters=args.filter.strip().split(',')): | |
# Two blank lines between two modules' texts | ||
sys.stdout.write(os.linesep * (1 + 2 * int(module != modules[-1]))) | ||
|
||
if args.html and args.html_index: | ||
# Add the root index.html at the top level. | ||
# The template expects `modules` to be Tuples of (name, docstring). | ||
module_tuples = sorted((module.name, module.docstring) | ||
for module in modules) | ||
index_text = pdoc._render_template('/html.mako', | ||
modules=module_tuples, | ||
**template_config) | ||
index_file = path.join(args.output_dir, 'index.html') | ||
try: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And this logic is adapted from |
||
with open(index_file, 'w+', encoding='utf-8') as w: | ||
w.write(index_text) | ||
except Exception: | ||
try: | ||
os.unlink(index_file) | ||
except Exception: | ||
pass | ||
raise | ||
|
||
|
||
if __name__ == "__main__": | ||
main(parser.parse_args()) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll name the arg whatever you want, but this is the general idea.