Add parsing of nested classes #176
Conversation
* Parse nested classes and present them in the class list * Changes _pep224_docstrings to use Doc.source instead of inspect to keep it DRY
There was a problem hiding this comment.
I'm thinking maybe we should actually make this the default (i.e. change Module.classes() directly). Classes are classes, not variables, and if they are exposed and meant to be used (they should probably not be nested), they better be documented thoroughly.
This also needs a unit test in pdoc.test.__init__.
| try: | ||
| tree = ast.parse(inspect.getsource(doc_obj.obj)) | ||
| tree = ast.parse(source) |
There was a problem hiding this comment.
This makes sense, but could you merge the two into the same error. ast.parse() surely throws something on an empty string or a None derived from empty_string or None?
kernc
added
enhancement
|
Hi, thanks for considering this. I can make the requested changes and add the test maybe from Monday. I am just sending so that you know I haven't just dropped this here and left :-). Cheers, |
|
No hurry, but this would sure make a nice addition! 😃 |
kernc
force-pushed
the
master
branch
3 times, most recently
from
456869b
to
94d26e8
Compare
Nested classes are incorrectly parsed as class variables. This commit fixes that and adds a method
all_classesinModulethat returns even the nested classes.Thanks,
Angelos