register on_finalize hook weights #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfffaaa
approved these changes
Dec 16, 2024
DocteurPing
approved these changes
Dec 16, 2024
talhadaar
deleted the
fix/1208987572609751-underestimated-hooks-weight
branch
sfffaaa
pushed a commit
that referenced
this pull request
Dec 16, 2024
* register on_finalize hook weights * account for a missing db read and write
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on_finalizehooks weight was underestimated according to security audit. For now, we've decided to manually account for reads/writes in hooks.