Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve "Result of method File_IMC_Build::validateParam() (void) is used" detected by PHPStan #12

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

matsuo
Copy link
Collaborator

@matsuo matsuo commented Jul 19, 2024

This PR resolves one error detected by PHPStan at level 0, changes the value of the return type in File_IMC_Build:: validateParam() because the return type in File_IMC_Build_Vcard::validateParam() is “mixed”.

Copy link
Member

@till till left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw you could also create a PR to add a ci job with phpstan and then resolve everything in the PR until it's green. :)

@@ -130,7 +130,7 @@ abstract function setVersion($text = '3.0');
* @param string $iter Optional, the iteration of the property. Only
* used for error messaging.
*
* @return void
* @return mixed Boolean true if the parameter is valid
* @throws File_IMC_Exception if not.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if I wrote this code. 😆

@matsuo
Copy link
Collaborator Author

matsuo commented Jul 20, 2024

Thank you for your comment!
I have created a PR ( #13 ) to add a CI job with PHPStan :)

@till till merged commit b0ad41d into pear:master Jul 20, 2024
4 checks passed
@matsuo matsuo deleted the resolve-an-error-detected-by-phpstan branch July 20, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants