Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HANSEL-118] Set querydsl and test setting #119

Merged
merged 2 commits into from
Jan 1, 2025
Merged

[HANSEL-118] Set querydsl and test setting #119

merged 2 commits into from
Jan 1, 2025

Conversation

weejinyoung
Copy link
Contributor

πŸ“„ [HANSEL-118] Set querydsl and test setting

Jira : [HANSEL-118] #118

✨ λ³€κ²½ 사항

  • κΈ°λŠ₯ μΆ”κ°€/λ³€κ²½ μ„€λͺ…

  • 쿼리 dsl μ„ΈνŒ…μ„ μ™„λ£Œν–ˆμŠ΅λ‹ˆλ‹€

  • κΈ°μ‘΄ api λͺ¨λ“ˆμ΄ persistence λͺ¨λ“ˆμ„ μŠ€μΊ”ν•˜λŠ” λ°©μ‹μ—μ„œ μ€‘λ³΅λœ 것을 μ œμ™Έν–ˆμŠ΅λ‹ˆλ‹€

  • μ„ΈνŒ… ν…ŒμŠ€νŠΈ μ½”λ“œλ₯Ό μž‘μ„±ν–ˆμŠ΅λ‹ˆλ‹€

πŸ“… μž‘μ—… 일정

  • Expected MD: 0.2 MD
  • Actual MD: 0.3 MD

Difference reason (If correct, no need.)

  • None.

βœ”οΈ 확인 사항

  • μ½”λ“œκ°€ 잘 μž‘λ™ν•˜λŠ”μ§€ ν™•μΈν–ˆλ‚˜μš”?
  • μƒˆλ‘œμš΄ κΈ°λŠ₯에 λŒ€ν•œ ν…ŒμŠ€νŠΈκ°€ μΆ”κ°€λ˜μ—ˆλ‚˜μš”?
  • λ¬Έμ„œκ°€ μ—…λ°μ΄νŠΈλ˜μ—ˆλ‚˜μš”?

@weejinyoung weejinyoung self-assigned this Jan 1, 2025
Shanate
Shanate reviewed Jan 1, 2025
View reviewed changes
Copy link
Contributor

@Shanate Shanate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Shanate
Shanate approved these changes Jan 1, 2025
View reviewed changes
Copy link
Contributor

@Shanate Shanate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

harvartz
harvartz approved these changes Jan 1, 2025
View reviewed changes
Copy link
Contributor

@harvartz harvartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

쿼리 DSL κΈ°λŒ€λ©λ‹ˆλ‹€ : )
LGTM

@weejinyoung weejinyoung merged commit c7087e0 into release/v0.2.0 Jan 1, 2025
2 checks passed
@weejinyoung weejinyoung deleted the feature/HANSEL-118 branch January 1, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harvartz harvartz harvartz approved these changes

@Shanate Shanate Shanate approved these changes

Assignees

@weejinyoung weejinyoung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weejinyoung @harvartz @Shanate