Fix server error when using gpgcheck/repo_gpgcheck

pulp#3298 moved gpg options to a single
field called "repo_config", but the deprecated "gpgcheck" and "repo_gpgcheck"
were still being passed to the models, which caused a TypeError when trying
to use them.

closes pulp#3357

CHANGES/3357.bugfix

@@ -0,0 +1 @@
+Fixed server error when trying to create repository with deprecated `gpgcheck` and `repo_gpgcheck`.

pulp_rpm/app/serializers/repository.py

@@ -105,6 +105,7 @@ class RpmRepositorySerializer(RepositorySerializer):
             "DEPRECATED: An option specifying whether a client should perform "
             "a GPG signature check on packages."
         ),
+        read_only=True,
     )
     repo_gpgcheck = serializers.IntegerField(
         max_value=1,
@@ -115,6 +116,7 @@ class RpmRepositorySerializer(RepositorySerializer):
             "DEPRECATED: An option specifying whether a client should perform "
             "a GPG signature check on the repodata."
         ),
+        read_only=True,
     )
     sqlite_metadata = serializers.BooleanField(
         default=False,

pulp_rpm/tests/functional/api/test_crud_repository.py

@@ -0,0 +1,5 @@
+def test_create_repo_with_deprecated_gpg_options_3357(rpm_repository_factory):
+    """Can create repository with deprecated gpgcheck and repo_gpgcheck options."""
+    assert rpm_repository_factory(repo_gpgcheck="0")
+    assert rpm_repository_factory(gpgcheck="0")
+    assert rpm_repository_factory(gpgcheck="0", repo_gpgcheck="0")