Re-write CurrencyMint implementation for new Currency protocol #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mordil
added
enhancement
santicarmo31
approved these changes
Jan 6, 2025
Motivation: CurrencyMint is a useful abstraction that allows creation of instances of Currency types dynamically, such as from API responses. The existing implementation doesn't correctly allow working with existential instances. There are also language features available in 5.7+ to better express things in the type system. Modifications: - Change: `CurrencyMint` to work with `any Currency` instead of `AnyCurrency` - Change: Codgen to return the new `Currency` conforming types rather than `AnyCurrency` - Change: Unit tests to be smaller units that better cover the different behaviors of the type Result: `CurrencyMint` is more flexible in the type system and plays better with modern Swift language features.
|
Latest push was a rebase off the target branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
CurrencyMint is a useful abstraction that allows creation of instances of Currency types dynamically, such as from API responses. The existing implementation doesn't correctly allow working with existential instances. There are also language features available in 5.7+ to better express things in the type system.
Modifications:
CurrencyMintto work withany Currencyinstead ofAnyCurrencyCurrencyconforming types rather thanAnyCurrencyResult:
CurrencyMintis more flexible in the type system and plays better with modern Swift language features.