Replace AnyCurrency, CurrencyProtocol with new Currency implementation #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mordil
added
enhancement
santicarmo31
approved these changes
Jan 6, 2025
Motivation: The new implementation has been proven to work, and the old implementation is ready to be replaced. Modifications: - Add: Usage examples of Currency as an existential - Change: ISO Currency type codegen to drop `_New_` prefix on new `Currency` conformances - Remove: `AnyCurrency`, `CurrencyProtocol` protocols and the codegen conformances - Remove: Unused `Decimal` extensions Result: The new `Currency` implementation is now the canonical representation in the library.
Mordil
force-pushed
the
remove-old-impl
branch
from
1ce803c to
5286492
Compare
|
Latest push was a rebase with the target branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The new implementation has been proven to work, and the old implementation is ready to be replaced.
Modifications:
_New_prefix on newCurrencyconformancesAnyCurrency,CurrencyProtocolprotocols and the codegen conformancesDecimalextensionsResult:
The new
Currencyimplementation is now the canonical representation in the library.