Skip to content

Commit

Permalink
feat: remove schema.typeName property from defaults
Browse files Browse the repository at this point in the history
Remove `schema.typeName` from the default config in order to support elasticsearch v8.

Prior to version 6 it was recommended to be "_doc", in es7 it was optional (but if specified it was required to be "_doc"), in es8 it's not allowed at all.

See: https://www.elastic.co/guide/en/elasticsearch/reference/7.17/removal-of-types.html

BREAKING CHANGE: Pelias no longer supports elasticsearch v6

This change drops support for elasticsearch v6 in order to support v8.
The current recommended version remains v7.

Closes #142
  • Loading branch information
michaelkirk authored Feb 1, 2024
1 parent a01cb6c commit 72e4a4c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions config/defaults.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,7 @@
}
},
"schema": {
"indexName": "pelias",
"typeName": "_doc"
"indexName": "pelias"
},
"logger": {
"level": "debug",
Expand Down
3 changes: 1 addition & 2 deletions test/expected-deep.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@
}
},
"schema": {
"indexName": "pelias",
"typeName": "_doc"
"indexName": "pelias"
},
"logger": {
"level": "debug",
Expand Down

0 comments on commit 72e4a4c

Please sign in to comment.