Use improvements when calculating pass rate #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out we were not using the number of `improvements` (tests expected to fail that actually passed) when calculating the total number of tests, and therefore the percentage pass rate of the complete test suite. This has the effect of under-reporting pass rate in situations where there are improvements. Also, the autocomplete output generator was not printing improvements, so it was looking like tests could "disappear" from results across different runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out we were not using the number of
improvements(tests expected to fail that actually passed) when calculating the total number of tests, and therefore the percentage pass rate of the complete test suite.This has the effect of under-reporting pass rate in situations where there are improvements.
Also, the autocomplete output generator was not printing improvements, so it was looking like tests could "disappear" from results across different runs.