add Header mode for credentials + docs #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejulius
approved these changes
Aug 24, 2020
There was a problem hiding this comment.
Cool, this is great.
Clean code, backwards compatible, adds some nice functionality.
Actually it even makes the code better, the API key logic should never have been hardcoded into the the test URLs.
Looks like the functionality is well covered by a new unit test, and the existing tests should ensure bits of behavior like our old vs new key sections from #198 continue to work.
I tried out all the options and they appear to work well.
We have a custom server in front of our pelias with some application level hacks. It uses http header auth. I would like to be able to use pelias fuzzy tester to see the differences, especially in autocomplete testing, between our raw backend pelias, and this hacked up proxied pelias. This change allows for that.
orangejulius
force-pushed
the
header-creds
branch
from
e613c59 to
e9ecaee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a custom server in front of our pelias with some application
level hacks. It uses http header auth. I would like to be able to use
pelias fuzzy tester to see the differences, especially in autocomplete
testing, between our raw backend pelias, and this hacked up proxied
pelias. This change allows for that.