Normalize unexpected properties #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without normalizers being applied, many unexpected property checks are likely passing, when they really should fail. For example, an unexpected property check for 'FOO', would not alert to the existice of 'Foo', even if there was a `toLowerCase` normalizer set for that property.
orangejulius
added a commit
to pelias/fuzzy-tests
that referenced
this pull request
Mar 8, 2022
This requires pelias/fuzzy-tester#208 to function but helps us measure duplicates
orangejulius
added a commit
to pelias/fuzzy-tests
that referenced
this pull request
Mar 8, 2022
This is required for `unexpected` checks to work properly: https://github.com/pelias/fuzzy-tester/releases/tag/v1.21.1 pelias/fuzzy-tester#208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without normalizers being applied, many unexpected property checks are likely passing, when they really should fail.
For example, an unexpected property check for 'FOO', would not alert to the existice of 'Foo', even if there was a
toLowerCasenormalizer set for that property.I've also included some nice refactoring in this PR. There is logic that can be shared across the now 3 places we do normalization (test expected properties, test unexpected properties, and the actual response properties)