logger performance warning #243
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missinglink
commented
Mar 12, 2020
| const street = require('../api/street'); | ||
| const near = require('../api/near'); | ||
| const pretty = require('../lib/pretty'); | ||
| const analyze = require('../lib/analyze'); |
There was a problem hiding this comment.
I just cleaned these up:
- make them
const - remove unused
require()
|
Since this is true everwhere, should we consider putting the warning somewhere in our general documentation? I'd rather we didn't add code to print this warning, especially in one of the (currently) least performance sensitive Pelias services. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of the
infoordebuglevel logging whenstdoutis aTTYresults in a ~25% performance hit.This PR simply adds a warning so developers are aware.
stdout is a TTY iteration_duration.........: avg=71.83ms min=15.43ms med=70.58ms max=135.37ms p(90)=86.29ms p(95)=92.87ms iterations.................: 10000 1388.112538/s stdout is /dev/null iteration_duration.........: avg=55.19ms min=23.44ms med=54.81ms max=81.28ms p(90)=62.97ms p(95)=65.49ms iterations.................: 10000 1806.935143/s