-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(poland): classifying more addresses for poland #174
feat(poland): classifying more addresses for poland #174
Conversation
Hi @JanF01 the unit test suite is currently failing, could you please have a look? |
Things should be running now. Turned out that one of the tests was an edge case, which has been specified before by @mansoor-sajjad here: |
Additionaly we have found a problem with street names that have this scheme: Prefix Place (Name/Adjective) or I'm not shure if it's too invasive, but I have added support for those scheme in the file: https://github.com/pelias/parser/tree/master/classifier/scheme/street.js I have checked locally if all the tests are going through. |
Generally speaking it's ok to make code changes as long as they don't break existing test cases. Looks like these don't, which is great 👍 |
Hi @JanF01 and thank you for your contribution. Could you move your change Resources in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed one commit for code formatting and diff cleaning
LGTM
👋 Adding Poland to the list of countries using a StreetPrefix as well as activating the
PostcodeClassifier
andPlaceClassifier
for Poland. Adding support for a new Street SchemeHere's the reason for this change 🚀
We are using the autocomplete query and we have found that many of the Polish streets were not recognized as such, we have also found problems with multi-word street names, but if Polish street prefixes will be recognized, than we could create a workaround.
We have also found that the Polish Postcodes are not recognized either. It would be great if we could get those to work 👍
Here's how others can test the changes 👀
I have written tests to see if things are working correctly