Fixing Docker Environment variable only getting checked for existence instead of value #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing that its only checking for the existence of the environment variable „SKIP_CADDY“ instead of checking for its value
Adding :- Syntax which ensures that, if SKIP_CADDY is unset, it will be treated as an empty string, which will not match "true". This avoids potential issues with unbound variables in some shell configurations where set -u (treating unset variables as an error) is enabled. (ChatGPT)
Fixed Syntax after last change
|
If you wish to use caddy then you comment it or set it to false otherwise set it to whatever but those two values and it will be disabled, i hardly see this condition useful. Besides we are probably gonna split Caddy out of the image so you can use whatever webserver you'd like and customize vHosts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing possible misinterpretations of the provided docker compose file.
It was only checking for the existence of the environment variable „SKIP_CADDY“ instead of checking for its value.
Now it‘s making sure that the Environment variable is actually set to true so if a value like false is set, caddy will still be active.