Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Docker Environment variable only getting checked for existence instead of value #700

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Fixing Docker Environment variable only getting checked for existence instead of value #700

merged 3 commits into from
Nov 4, 2024

Commits on Nov 4, 2024

  1. Update entrypoint.sh 

    Fixing that its only checking for the existence of the environment variable „SKIP_CADDY“ instead of checking for its value
    @BlockyBlockling
    BlockyBlockling authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    1a8321c View commit details
    Browse the repository at this point in the history

  2. Update entrypoint.sh 

    Adding :- Syntax which ensures that, if SKIP_CADDY is unset, it will be treated as an empty string, which will not match "true". This avoids potential issues with unbound variables in some shell configurations where set -u (treating unset variables as an error) is enabled.

(ChatGPT)
    @BlockyBlockling
    BlockyBlockling authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    7514206 View commit details
    Browse the repository at this point in the history

  3. Update entrypoint.sh 

    Fixed Syntax after last change
    @BlockyBlockling
    BlockyBlockling authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    968239b View commit details
    Browse the repository at this point in the history