Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old admin area #648

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Remove old admin area #648

wants to merge 14 commits into from

Conversation

lancepioch
Copy link
Member

No description provided.

@lancepioch lancepioch self-assigned this Oct 20, 2024
Boy132
Boy132 reviewed Oct 21, 2024
View reviewed changes
app/Listeners/Auth/AuthenticationListener.php Outdated Show resolved Hide resolved
app/Listeners/Auth/PasswordResetListener.php Outdated Show resolved Hide resolved
app/Listeners/Auth/TwoFactorListener.php Outdated Show resolved Hide resolved
resources/views/vendor/notifications/email.blade.php Outdated Show resolved Hide resolved
resources/views/vendor/notifications/email-plain.blade.php Outdated Show resolved Hide resolved
RMartinOscar
RMartinOscar reviewed Oct 21, 2024
View reviewed changes
routes/console.php Outdated Show resolved Hide resolved
@Boy132 Boy132 mentioned this pull request Oct 24, 2024
Closed
5 tasks
@Boy132 Boy132 linked an issue Oct 24, 2024 that may be closed by this pull request
"Interface not found" error when running composer install on main #573
Open
@RMartinOscar
Copy link
Contributor

app/Exceptions/Solutions/ManifestDoesNotExistSolution.php
and

panel/composer.json

Line 53 in 73f056c

"spatie/laravel-ignition": "^2.7"

should also get removed now that its not used anywhere.

@lancepioch
Copy link
Member Author

@RMartinOscar ignition solutions are used in debug mode

Boy132
Boy132 requested changes Nov 5, 2024
View reviewed changes
resources/views/templates/wrapper.blade.php Outdated Show resolved Hide resolved
app/Http/ViewComposers/AssetComposer.php Show resolved Hide resolved
app/Services/Helpers/AssetHashService.php Outdated Show resolved Hide resolved
@notAreYouScared
Copy link
Member

The client ar
ea is working as expected. LGTM

@Boy132 @RMartinOscar Could you still take a look at it?

@RMartinOscar
Copy link
Contributor

RMartinOscar commented Nov 7, 2024 •
edited
Loading

image
When clicking autoDeploy

Fixed in #701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMartinOscar RMartinOscar RMartinOscar left review comments

@Boy132 Boy132 Boy132 requested changes

@notAreYouScared notAreYouScared notAreYouScared approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@lancepioch lancepioch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Interface not found" error when running composer install on main
4 participants
@lancepioch @RMartinOscar @notAreYouScared @Boy132