Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear webhook cache when webhooks are deleted #695

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Clear webhook cache when webhooks are deleted #695

merged 2 commits into from
Nov 7, 2024
+42 −6

Conversation

lancepioch
Copy link
Member

Fixes #689

@lancepioch lancepioch self-assigned this Oct 31, 2024
@lancepioch lancepioch added the 🐛 bug Something isn't working label Oct 31, 2024
@lancepioch lancepioch marked this pull request as draft November 1, 2024 23:37
RMartinOscar
RMartinOscar requested changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@RMartinOscar RMartinOscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this on top

use Illuminate\Support\Collection;

@notAreYouScared notAreYouScared marked this pull request as ready for review November 7, 2024 22:16
@notAreYouScared notAreYouScared merged commit 47bd728 into pelican-dev:main Nov 7, 2024
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RMartinOscar RMartinOscar RMartinOscar approved these changes

@notAreYouScared notAreYouScared notAreYouScared approved these changes

Assignees

@lancepioch lancepioch

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deleted Webhook still triggers
4 participants
@lancepioch @notAreYouScared @RMartinOscar @go-vehikl