-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write special env variables at the very end of the installer #699
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
->hidden(fn (Get $get) => $get('env_general.SESSION_DRIVER') != 'redis' && $get('env_general.QUEUE_CONNECTION') != 'redis' && $get('env_general.CACHE_STORE') != 'redis'), |
->hidden(fn (Get $get) => $get('env_special.SESSION_DRIVER') != 'redis' && $get('env_general.QUEUE_CONNECTION') != 'redis' && $get('env_special.CACHE_STORE') != 'redis'),
ToggleButtons::make('env_general.CACHE_STORE') |
ToggleButtons::make('env_special.CACHE_STORE')
We have to change those too
Hidden check is fixed. And the cache driver is fine, it doesn't need special treatment. |
I had the same 500 as before when hitting next in the db step with redis selected as cache store it errors immediately i can't even fill in the redis host & pass so it uses no password cause no redis env is set yet.
|
Please try again and if you still get a 500 post the error. |
https://paste.pelistuff.com/kin4 |
We should validate the Redis connection too and make sure it works before saving it in the .env, good catch! |
Yeah so that's a totally different error...
The redis connection is validated - in the Redis step. The problem is the |
Closes #696
This makes sure that "special" env variables (in this case the
SESSION_DRIVER
) are only written to the .env file at the very end of the installer.The
SESSION_DRIVER
variable is the only variable that directly affects the installer when being changed.