Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve egg import error handling #703

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Improve egg import error handling #703

merged 2 commits into from
Nov 7, 2024

Conversation

Boy132
Copy link
Member

@Boy132 Boy132 commented Nov 7, 2024

  • Make sure file_put_contents was successful.
  • Throw InvalidFileUploadException instead of JsonException when json_decode fails.
  • Show exception message in notification.

@notAreYouScared notAreYouScared merged commit a9b76a0 into pelican-dev:main Nov 7, 2024
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
@Boy132 Boy132 deleted the improve/egg-import-error-handling branch November 8, 2024 07:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@notAreYouScared notAreYouScared notAreYouScared approved these changes

@lancepioch lancepioch lancepioch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Boy132 @lancepioch @notAreYouScared