forked from aio-libs/aiosmtpd
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Activate LOTS of flake8 plugins to enforce code hygiene
Selection criteria: * Must be useful, even if many warnings For example: Plugins related to annotations. As @warsaw raised in aio-libs#128, it's a good idea to type-annotate as much as possible. * If not simple, must be maintained "maintained" here is overly-simplified to mean only "master has an update in 2020 or later". Some plugins have not received updates for a long time, but their logic are simple and really does not need updates, so those can also be included on a case-by-case basis. * Will not need significant change in logic Adding annotations, removing temp vars used just for return values, those are not logic changes. So even if lots of instances need to be fixed, that is okay. Plugins that need a restructurization of the logic flow (e.g., "flake8-cognitive-complexity") should not be included; or, if included, should not be activated. At least not until the next Epic.
- Loading branch information
Showing
2 changed files
with
74 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters