Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPENSOURCE-73 :: Adding a KMP QRCode library #87

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

OPENSOURCE-73 :: Adding a KMP QRCode library #87

wants to merge 5 commits into from

Conversation

alexs60
Copy link
Contributor

@alexs60 alexs60 commented Dec 20, 2024

Pull Request Template

Description

  • remove the zxing qrcode library
  • add a new compose multi platform qrcode library
  • let it work in composeTestApp
  • let it work in the Android app

Related Issues

Checklist

  • Have you tested your changes locally?
  • Have you reviewed the code for any potential issues?
  • Have you documented any necessary changes in the project's documentation?
  • Have you added any necessary tests for your changes?
  • Have you updated any relevant dependencies?

Additional Notes

  • Add any additional notes or comments that may be helpful for reviewers.

Android simulator
Screenshot 2024-12-20 at 12 44 40 PM

IOS on real device

1000059410

@michaeltchuang michaeltchuang added enhancement New feature or request external contribution open source code contributions labels Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasin-ce yasin-ce Awaiting requested review from yasin-ce yasin-ce will be requested when the pull request is marked ready for review yasin-ce is a code owner

@mitsinsar mitsinsar Awaiting requested review from mitsinsar mitsinsar will be requested when the pull request is marked ready for review mitsinsar is a code owner

@michaeltchuang michaeltchuang Awaiting requested review from michaeltchuang michaeltchuang will be requested when the pull request is marked ready for review michaeltchuang is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request external contribution open source code contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexs60 @michaeltchuang