EVEREST-866 PG PITR fallback to heuristics (#828)

percona · Nov 12, 2024 · a45c5f9 · a45c5f9
1 parent becc9e1
commit a45c5f9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/api/database_cluster.go b/api/database_cluster.go
@@ -508,10 +508,9 @@ func getDefaultUploadInterval(engine everestv1alpha1.Engine, uploadInterval *int
 		// so we still use heuristics
 		return valueOrDefault(uploadInterval, psmdbDefaultUploadInterval)
 	case everestv1alpha1.DatabaseEnginePostgresql:
-		// latest restorable time appeared in PG 2.4.0
-		if common.CheckConstraint(version, "<2.4.0") {
-			return valueOrDefault(uploadInterval, pgDefaultUploadInterval)
-		}
+		// latest restorable time appeared in PG 2.4.0, however it's not reliable https://perconadev.atlassian.net/browse/K8SPG-681
+		// so we still use heuristics
+		return valueOrDefault(uploadInterval, pgDefaultUploadInterval)
 	}
 	// for newer versions don't use the heuristics, so return 0 upload interval
 	return 0

diff --git a/api/database_cluster_test.go b/api/database_cluster_test.go
@@ -137,19 +137,19 @@ func TestGetDefaultUploadInterval(t *testing.T) {
 			name:     "new pg, no interval is set",
 			engine:   everestv1alpha1.Engine{Type: everestv1alpha1.DatabaseEnginePostgresql, Version: "2.4.0"},
 			interval: nil,
-			expected: 0,
+			expected: pgDefaultUploadInterval,
 		},
 		{
 			name:     "new pg, interval is set",
 			engine:   everestv1alpha1.Engine{Type: everestv1alpha1.DatabaseEnginePostgresql, Version: "2.4.0"},
 			interval: pointer.ToInt(1000),
-			expected: 0,
+			expected: 1000,
 		},
 		{
 			name:     "newer pg",
 			engine:   everestv1alpha1.Engine{Type: everestv1alpha1.DatabaseEnginePostgresql, Version: "2.4.1"},
 			interval: nil,
-			expected: 0,
+			expected: pgDefaultUploadInterval,
 		},
 	}
 	for _, tc := range cases {