Add Sharding Support to PSMDB Demand Backup Test

[edithturn]

Demand backup test for PSMDB to include sharding:

• Set up a sharded cluster with 2 shards and 3 nodes each.
• Add a test collection and enable sharding on it.
• Add an unsharded test collection (expected to land on the second shard).
• Perform backup, drop data, restore, and verify data integrity.
• Clean up by deleting backups, restores, and the cluster.

The reference script for this implementation was: demand-backup.e2e.ts

[tplavcic]

Add parameter to this function for collection so you can just call it twice in the test with different collection parameter so that you don't duplicate the code for t1 and t2.

[edithturn]

Added a new parameter for the collection

export const validateMongoDBSharding = async (
  cluster: string,
  namespace: string,
  collectionName: string
) => {
  const collectionString = await queryPSMDB(
    cluster,
    namespace,
    'config',
    `db.collections.find({ _id: \\"test.${collectionName}\\" });`
  );

[tplavcic]

Move createIndex to prepareMongoDBTestDB function.

[edithturn]

Yes, now createIndex is inside prepareMongoDBTestDB

[tplavcic]

Move createIndex to prepareMongoDBTestDB function.

[edithturn]

Done!

[tplavcic]

Please call the keys the same as in t1, so { a: 1 }, { a: 2 }, { a: 3 }. It will simplify things because we will have 1 function for configureMongoSharding which will just take parameter for collection.

[edithturn]

Considering the keys of booth collections the same:

t1 Collection String: 
  
    _id: 'test.t1',
    key: { a: 1 },

t2 Collection String:

    _id: 'test.t2',
    key: { a: 1 },

[tplavcic]

Add parameter for collection name to this function and call it twice so that there is no code duplication for t1 and t2.
enableSharding can be called in the test directly or it can be left here because I don't think it will have any effect if the sharding is already enabled on the collection.

[edithturn]

I created shardCollection inside configureMongoDBSharding, and calling it to times for t1 and t2

const shardCollection = async (
    collectionName: string,
    key: object,
    splitKey: object
  ) => {
    await queryPSMDB(
      cluster,
      namespace,
      'admin',
      `sh.shardCollection(\\"test.${collectionName}\\", ${JSON.stringify(key)});`
    );

[tplavcic]

It seems strange exporting this from the test and importing it into helper functions. Let's create a function psmdbShardingEnabled in db-cmd-line.ts and then use it inside the same file.

[edithturn]

I opted for this:

// Enable replicaSet option if sharding is enabled
  const isShardingEnabled = true;
  const replicaSetOption = isShardingEnabled ? '' : '&replicaSet=rs0';

Since the function queryPSMDB will be call when we test sharding, so I am assuming it will be activate it, let me know your toughs, Tomislav.

[tplavcic]

When we create a new function in db-cmd-line.ts we don't need this here. Also we want to check if sharding is actually enabled in the backend (api call) and not did we just click on something in UI.

[edithturn]

Agree, I removed!

[tplavcic]

Remove comment since test description below has the same.

[edithturn]

Done!

[tplavcic]

remove

[tplavcic]

Add something like:

expect(addedCluster?.spec.sharding.enabled).toBe(true)
expect(addedCluster?.spec.sharding.shards).toBe(2)
expect(addedCluster?.spec.sharding.configServer.replicas).toBe(3)
expect(addedCluster?.spec.proxy.replicas).toBe(3)

[edithturn]

Done!

[solovevayaroslavna]

i think this part should be moved to utils to avoid duplication 🤔 we call the cluster creation button in a lot of places