Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-3106: Be consistent and use MONGODB_URI everywhere. #116

Merged
merged 3 commits into from
Nov 21, 2018

Conversation

TinLe
Copy link

@TinLe TinLe commented Sep 17, 2018

Be consistent in usage of env var MONGODB_URI. Currently, documentation say "MONGODB_URL", but code is looking for MONGODB_URI.

@CLAassistant
Copy link

CLAassistant commented Sep 17, 2018

CLA assistant check
All committers have signed the CLA.

Copy link

@arvenil arvenil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smartinov
Could you also drop

 	uri := os.Getenv("MONGODB_URI")
 	if uri != "" {
		uriF = &uri
	}

for

uriF := &uri

https://github.com/percona/mongodb_exporter/blob/master/mongodb_exporter.go#L87-L90
?

@arvenil
Copy link

arvenil commented Oct 15, 2018

@rnovikovP Invalidates #113, you can read my review for explanation #113 (review)

@arvenil arvenil changed the title Be consistent and use MONGODB_URI everywhere. PMM-3106: Be consistent and use MONGODB_URI everywhere. Oct 15, 2018
@codecov
Copy link

codecov bot commented Nov 15, 2018

Codecov Report

Merging #116 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #116   +/-   ##
=======================================
  Coverage   28.92%   28.92%           
=======================================
  Files          42       42           
  Lines        2282     2282           
=======================================
  Hits          660      660           
  Misses       1584     1584           
  Partials       38       38
Impacted Files Coverage Δ
mongodb_exporter.go 3.5% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76913b6...a28942b. Read the comment docs.

@rishtham
Copy link

rishtham commented May 7, 2020

hi,
Is there a way to hide the password in mongodb_url string as the password is appearing in string .
export MONGODB_URI=mongodb://mongodb_exporter:s3cr3tpassw0rd@localhost:27017
thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants