-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMM-3106: Be consistent and use MONGODB_URI everywhere. #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smartinov
Could you also drop
uri := os.Getenv("MONGODB_URI")
if uri != "" {
uriF = &uri
}
for
uriF := &uri
https://github.com/percona/mongodb_exporter/blob/master/mongodb_exporter.go#L87-L90
?
@rnovikovP Invalidates #113, you can read my review for explanation #113 (review) |
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
=======================================
Coverage 28.92% 28.92%
=======================================
Files 42 42
Lines 2282 2282
=======================================
Hits 660 660
Misses 1584 1584
Partials 38 38
Continue to review full report at Codecov.
|
hi, |
Be consistent in usage of env var MONGODB_URI. Currently, documentation say "MONGODB_URL", but code is looking for MONGODB_URI.