Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow IDN #153

Merged
merged 1 commit into from
May 30, 2024
Merged

Allow IDN #153

merged 1 commit into from
May 30, 2024

Conversation

TimothyAlexisVass
Copy link
Contributor

This allows International Domain Names.

@TimothyAlexisVass
Allow IDN
4e69ce9 
This allows International Domain Names.
@kritik kritik merged commit 80e5024 into perfectline:master May 30, 2024
0 of 3 checks passed
@TimothyAlexisVass
Copy link
Contributor Author

I'm sorry, this is incomplete because it will allow http://$$$.com which should be invalid.
It is a lot more complicated.
IDNs are specified by Network Working Group RFC 3490: Internationalizing Domain Names in Applications (IDNA):
The algorithm is specified here:
https://rfc-annotations.research.icann.org/rfc3490.html#section-4

@TimothyAlexisVass
Copy link
Contributor Author

Here is a gem which claims to implement the specifications:
https://github.com/deepfryed/idn-ruby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kritik kritik kritik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimothyAlexisVass @kritik