fix: rename ansible-role-nginx to jdauphant.nginx #2
Conversation
|
Hi, I really appreciate that you are using this code for your own fork and continuing the development. My use of this code is only occasionally these days so the development is very slow. Your fork looks to have improved the compiling stages which were a little cumbersome and prone to breaking. I think my fork of this code likely doesn't need the change to using jdauphant.nginx as this is read-only for a while now. My fork of that repo has a couple of minor changes to work with Oracle Linux 8 however there are other forks plus the official nginx ansible playbooks which would seem like better targets for future development in my view. This PR can remain open so people can easily include it if this wish, with some luck they will simply pull for your fork directly however. Best of luck with your endeavours on this. :) |
|
Hi, @perryk, thanks for taking such good care of the project, that's so nice! Yes, honestly, the PR was opened accidentally: my initial intention was to merge it against the main branch of my repo. Once it was already open, I considered it was not harmful and decided to leave it open. For the sake of communicating alternatives to your role, I must add a third one –which I sadly found after developing mine– that supports the official NGINX role. Since jdauphant has stated that the role maintenance is frozen, I agree this seems like a smart move. |
|
All good, it is sometimes better to write your own changes and learn how things work too so having your own role is likely still a good thing to have. Perhaps some of the work in third fork which supports the official NGINX role could be useful. Certainly if I ever have a chance to take up further development of this again it is something I would explore. |
|
Just a note here, the jdauphant.nginx role is not longer read-only, but it has only 1 commit so is still pretty much the same. I think the role worked well the last time I used it, but if anyone is working on their own for this they still might want to look at the official NGINX role. |
No description provided.