[ENHANCEMENT] Update dependencies and improve docs #21
+691
−290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibakshay
force-pushed
the
akshay/update-dependencies
branch
2 times, most recently
from
254f17c
to
249f796
Compare
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
ibakshay
force-pushed
the
akshay/update-dependencies
branch
from
249f796
to
249615f
Compare
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
ibakshay
changed the title
|
@ibakshay thank you for your contribution!. Can you please take a look at the tests, they might need an update. |
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
My pleasure. Thanks a lot for your review. The test is failing due to this serialization issue. I have already created a PR in prometheus/common repository for the fix. The test should be successfully after PR in prometheus/common gets merged. |
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
perses-server-urlflag for localhost testing:fixes #16 cloudoperators/greenhouse-extensions#419