Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bite Selection: Second Click #61

Open
amalnanavati opened this issue May 31, 2023 · 0 comments
Open

Bite Selection: Second Click #61

amalnanavati opened this issue May 31, 2023 · 0 comments
Labels
critical-path Issues that are critical path for deployment enhancement New feature or request

Comments

@amalnanavati
Copy link
Contributor

In the current implementation of the real food segmentation action server (ada_feeding#24), the action server rejects any new goals until the old goal is done completing.

However, on the app side, if the user clicks on the image again while the action server is still executing the first action, the app displays "The robot encountered an error detecting food" which is a misleading error message.

Of course one way to address this is to disable additional clicks of the image while the app is waiting to hear back from an action server. However, this is undesirable, because if an action server messes up and doesn't return, we don't want to prevent the user from re-clicking.

So instead, the app should probably keep a counter of the number of open (i.e., a result, error, or cancellation hasn't yet been received) action server goal requests it sent. If that number is is > 1 and it receives a cancellation response, instead of displaying the "robot encountered an error" message, it should display "Robot is currently processing a previous click" message.

@amalnanavati amalnanavati added enhancement New feature or request critical-path Issues that are critical path for deployment labels May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical-path Issues that are critical path for deployment enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant