fix #53: Issue and PR autocomplete not working in Octo files #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Seems to be caused by the Octo filetype - See petertriho#53
Finally figured out the source of the problem. This commit 7b292e1 was pushed to account for GH Enterprise but Octo default settings leaves this blank. This fix accounts for that as well. ref: petertriho#53
GitMurf
changed the title
GitMurf
changed the title
|
Thanks for the PR. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if you have any questions. I don't have any Lua experience but seems pretty straight forward.
The issue seems to be that this commit 7b292e1 was pushed to account for GH Enterprise URLs, but Octo default settings leaves this config item (
github_hostname) empty by default. I added a fallback ofgithub.comif it is empty.Additionally Octo just made a change to their API so had to replace
get_config()withvalues... see here: pwntester/octo.nvim@b537100ref: #53