Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#151 Create organization tasks page #159

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LukasKri
Copy link
Contributor

I've created organization tasks page with proper styles. I'm planning to add tests later.

Resolves #151.

Copy link
Collaborator

@budaman budaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pretty clean, and the required implementation is done correctly. The only improvement we could have tests for the page and Organization task card as a separate component.

return (
<Page title="Organization Tasks">
{data &&
data.organizationTasks.map(task => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a OrganizationTask type

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I added the type. Do you want me to extract the Organization task card as a separate component or just leave it for the future improvements?

@LukasKri LukasKri force-pushed the 151-create-organization-tasks-page branch from 30654b6 to 7ac7233 Compare May 9, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create organization tasks page. ON HOLD
2 participants