Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

picoweb: Add javascript mime type. #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

orzechow
Copy link
Contributor

The get_mime_type function supports HTML pages, CSS Stylesheets and basic graphic formats.
With JavaScript added all basic web page elements can now be served.

@pfalcon
Copy link
Owner

pfalcon commented Jan 24, 2018

This seems to have been already suggested in #23 . My question remains the same: Does this solve a real issue? If so, I'd like that issue to be described and demonstrated.

An example of what I mean can be seen here: micropython/micropython-lib#247 . An issue was reported, and the reporter made steps to back it by normative references. Turned out, such references are not conclusive, but with a (good) real-world example, the change was made after all.

@pfalcon pfalcon force-pushed the master branch 2 times, most recently from 1fd3eec to 46f90d6 Compare February 24, 2018 20:36
@pfalcon pfalcon force-pushed the master branch 2 times, most recently from e3acfcc to dbc15e3 Compare December 29, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants