Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRON-18508] [MINOR] Prepare repository for open sourcing #10

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

ClaudiaGivan
Copy link
Collaborator

  • add license
  • add code of conduct
  • remove sensitive data from files

LICENSE Outdated
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright 2023 Heather McNamee <[email protected]>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@August1914 I found that here should be put the name of the contributor who made the first commit, in this case, Heather.
Could you please confirm if this is correct?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ClaudiaGivan I don't think it's necessary to make copyright attribution here. Where did you find the information that said so?

Copy link

@August1914 August1914 Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you think about it — Heather intended for us to replace that with an appropriate value (if any) for copyright attribution.

Copy link
Collaborator Author

@ClaudiaGivan ClaudiaGivan Jan 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dickolsson The official documentation or guide is this: https://opensource.org/license/apache-2-0/
But I found the info in this blog post: https://www.linkedin.com/pulse/how-apply-apache-20-license-your-open-source-software-vladimír-gorej/
where it says "The name of the copyright holder is the name of the first committer to the project"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dickolsson the guidance referenced by Claudia above looks correct: a copyright should be included under the terms of Apache 2.0, and that the copyright holder should be the first committer: in our case, Heather. I suppose the question is if there is a general policy to not leave any reference to pfizer.com. If that's the case, I think we should include still include a copyright statement, but use a non-pfizer email, for example, claudia's. Without the copyright statement, I think anyone can package the library for resale, despite the Apache 2.0 provisions.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@August1914 @ClaudiaGivan For all intents and purposes, I think Claudia will be the first committer once the repo history is rebased clean before the release (as per Pfizer's open source policy: https://confluence.pfizer.com/display/DSOEPipeline/Publishing+Open+Source+Code

@ClaudiaGivan Do you have a non-Pfizer email that you would be comfortable with sharing publicly in the Copyright line there?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dickolsson yes, I will use the github email: [email protected]

@ClaudiaGivan
Copy link
Collaborator Author

Once this PR is merged, a subsequent PR will be initiated, dedicated to filtering out all the commits from the commit history that contain sensitive data in the specified file. This ensures the thorough removal of the sensitive information from the commit history.

examples/example.js Show resolved Hide resolved
LICENSE Outdated
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright 2023 Heather McNamee <[email protected]>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ClaudiaGivan I don't think it's necessary to make copyright attribution here. Where did you find the information that said so?

- add license
- add code of conduct
@ClaudiaGivan ClaudiaGivan merged commit 84af810 into main Feb 14, 2024
4 checks passed
@ClaudiaGivan ClaudiaGivan deleted the tron-18508 branch February 14, 2024 12:51
ClaudiaGivan added a commit that referenced this pull request Feb 14, 2024
[TRON-18508] [MINOR] Prepare repository for open sourcing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants