Separate not equal collection cases for Equals/GetHashCode / Refactor…

… tests
pfpack · Jan 1, 2025 · c0ea8f7 · c0ea8f7
1 parent 5a7e950
commit c0ea8f7
Show file tree

Hide file tree

Showing 19 changed files with 154 additions and 69 deletions.
diff --git a/...rers/Collections.Generic.EqualityComparers.Tests/Array/ArrayEqualityComparer_TestsBase.cs b/...rers/Collections.Generic.EqualityComparers.Tests/Array/ArrayEqualityComparer_TestsBase.cs
@@ -84,15 +84,15 @@ public static void Test_Equals_InputsAreNotEqual_ExpectFalse(CaseParamOfArray<T>
 
     public static TheoryData<CaseParamOfArray<T>, CaseParamOfArray<T>> InputsAreEqualCases()
         =>
-        MapEqualsCases(CaseSources.EqualArrays<T>());
+        MapEqualsCases(EqualCaseSource.EqualArrays<T>());
 
     public static TheoryData<CaseParamOfArray<T>, CaseParamOfArray<T>> Equals_InputsAreNotEqualCases()
         =>
-        MapEqualsCases(CaseSources.Equals_NotEqualArrays<T>());
+        MapEqualsCases(NotEqualCaseSource_Equals.NotEqualArrays<T>());
 
     public static TheoryData<CaseParamOfArray<T>, CaseParamOfArray<T>> GetHashCode_InputsAreNotEqualCases()
         =>
-        MapEqualsCases(CaseSources.GetHashCode_NotEqualArrays<T>());
+        MapEqualsCases(NotEqualCaseSource_GetHashCode.NotEqualArrays<T>());
 
     private static ArrayEqualityComparer<T> BuildComparer()
         =>

diff --git a/...parers/Collections.Generic.EqualityComparers.Tests/CaseSources/CaseSources.EqualArrays.cs b/...parers/Collections.Generic.EqualityComparers.Tests/CaseSources/CaseSources.EqualArrays.cs
diff --git a/...lections.Generic.EqualityComparers.Tests/CaseSources/CaseSources.Equals_NotEqualArrays.cs b/...lections.Generic.EqualityComparers.Tests/CaseSources/CaseSources.Equals_NotEqualArrays.cs
diff --git a/...ons.Generic.EqualityComparers.Tests/CaseSources/CaseSources.GetHashCode_NotEqualArrays.cs b/...ons.Generic.EqualityComparers.Tests/CaseSources/CaseSources.GetHashCode_NotEqualArrays.cs
diff --git a/...-equalitycomparers/Collections.Generic.EqualityComparers.Tests/CaseSources/CaseSources.cs b/...-equalitycomparers/Collections.Generic.EqualityComparers.Tests/CaseSources/CaseSources.cs
diff --git a/...ources.InnerEqualArraysOfInt32Nullable.cs → ...Source.InnerEqualArraysOfInt32Nullable.cs b/...ources.InnerEqualArraysOfInt32Nullable.cs → ...Source.InnerEqualArraysOfInt32Nullable.cs
@@ -4,7 +4,7 @@
 
 namespace PrimeFuncPack.Collections.Generic.EqualityComparers.Tests;
 
-partial class CaseSources
+partial class EqualCaseSource
 {
     private static IEnumerable<(int?[]? X, int?[]? Y)> InnerEqualArraysOfInt32Nullable()
     {

diff --git a/...s/CaseSources.InnerEqualArraysOfString.cs → ...ualCaseSource.InnerEqualArraysOfString.cs b/...s/CaseSources.InnerEqualArraysOfString.cs → ...ualCaseSource.InnerEqualArraysOfString.cs
@@ -4,7 +4,7 @@
 
 namespace PrimeFuncPack.Collections.Generic.EqualityComparers.Tests;
 
-partial class CaseSources
+partial class EqualCaseSource
 {
     private static IEnumerable<(string?[]? X, string?[]? Y)> InnerEqualArraysOfString()
     {

diff --git a/...seSources/CaseSources.InnerEqualArrays.cs → ...rers.Tests/CaseSources/EqualCaseSource.cs b/...seSources/CaseSources.InnerEqualArrays.cs → ...rers.Tests/CaseSources/EqualCaseSource.cs
@@ -3,9 +3,9 @@
 
 namespace PrimeFuncPack.Collections.Generic.EqualityComparers.Tests;
 
-partial class CaseSources
+internal static partial class EqualCaseSource
 {
-    private static IEnumerable<(T[]? X, T[]? Y)> InnerEqualArrays<T>()
+    internal static IEnumerable<(T[]? X, T[]? Y)> EqualArrays<T>()
     {
         if (typeof(T) == typeof(string))
         {

diff --git a/...ces.InnerNotEqualArraysOfInt32Nullable.cs → ...als.InnerNotEqualArraysOfInt32Nullable.cs b/...ces.InnerNotEqualArraysOfInt32Nullable.cs → ...als.InnerNotEqualArraysOfInt32Nullable.cs
@@ -4,7 +4,7 @@
 
 namespace PrimeFuncPack.Collections.Generic.EqualityComparers.Tests;
 
-partial class CaseSources
+partial class NotEqualCaseSource_Equals
 {
     private static IEnumerable<(int?[]? X, int?[]? Y)> InnerNotEqualArraysOfInt32Nullable()
     {
@@ -45,7 +45,7 @@ partial class CaseSources
         );
         yield return (
             new int?[] { 1, 2, 3 },
-            new int?[] { 1, 1, 3 }
+            new int?[] { 1, 0, 3 }
         );
         yield return (
             new int?[] { 1, 2, 3, 4 },

diff --git a/...aseSources.InnerNotEqualArraysOfString.cs → ...rce_Equals.InnerNotEqualArraysOfString.cs b/...aseSources.InnerNotEqualArraysOfString.cs → ...rce_Equals.InnerNotEqualArraysOfString.cs
@@ -4,7 +4,7 @@
 
 namespace PrimeFuncPack.Collections.Generic.EqualityComparers.Tests;
 
-partial class CaseSources
+partial class NotEqualCaseSource_Equals
 {
     private static IEnumerable<(string?[]? X, string?[]? Y)> InnerNotEqualArraysOfString()
     {
@@ -45,7 +45,7 @@ partial class CaseSources
         );
         yield return (
             new[] { "1", "2", "3" },
-            new[] { "1", "1", "3" }
+            new[] { "1", "0", "3" }
         );
         yield return (
             new[] { "1", "2", "3", "4" },

diff --git a/...rers/Collections.Generic.EqualityComparers.Tests/CaseSources/NotEqualCaseSource_Equals.cs b/...rers/Collections.Generic.EqualityComparers.Tests/CaseSources/NotEqualCaseSource_Equals.cs
@@ -0,0 +1,30 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+
+namespace PrimeFuncPack.Collections.Generic.EqualityComparers.Tests;
+
+internal static partial class NotEqualCaseSource_Equals
+{
+    internal static IEnumerable<(T[]? X, T[]? Y)> NotEqualArrays<T>()
+        =>
+        InnerNotEqualArrays<T>().ToArray() switch
+        {
+            var pairs => pairs.Concat(pairs.Select(pair => (pair.Y, pair.X)))
+        };
+
+    private static IEnumerable<(T[]? X, T[]? Y)> InnerNotEqualArrays<T>()
+    {
+        if (typeof(T) == typeof(string))
+        {
+            return (IEnumerable<(T[]? X, T[]? Y)>)InnerNotEqualArraysOfString();
+        }
+
+        if (typeof(T) == typeof(int?))
+        {
+            return (IEnumerable<(T[]? X, T[]? Y)>)InnerNotEqualArraysOfInt32Nullable();
+        }
+
+        throw new ArgumentException($"An unexpected type ({typeof(T).Name}).", nameof(T));
+    }
+}
diff --git a/...rs.Tests/CaseSources/NotEqualCaseSource_GetHashCode.InnerNotEqualArraysOfInt32Nullable.cs b/...rs.Tests/CaseSources/NotEqualCaseSource_GetHashCode.InnerNotEqualArraysOfInt32Nullable.cs
@@ -0,0 +1,47 @@
+#pragma warning disable IDE0300 // Simplify collection initialization
+
+using System.Collections.Generic;
+
+namespace PrimeFuncPack.Collections.Generic.EqualityComparers.Tests;
+
+partial class NotEqualCaseSource_GetHashCode
+{
+    private static IEnumerable<(int?[]? X, int?[]? Y)> InnerNotEqualArraysOfInt32Nullable()
+    {
+        yield return (
+            null,
+            EmptyArray<int?>.Value);
+        yield return (
+            null,
+            new int?[] { 1 }
+        );
+        yield return (
+            EmptyArray<int?>.Value,
+            new int?[] { 1 }
+        );
+        yield return (
+            new int?[] { 1 },
+            new int?[] { 1, 2 }
+        );
+        yield return (
+            new int?[] { 1, 2 },
+            new int?[] { 1, 2, 3 }
+        );
+        yield return (
+            new int?[] { null },
+            new int?[] { 1 }
+        );
+        yield return (
+            new int?[] { 1 },
+            new int?[] { 2 }
+        );
+        yield return (
+            new int?[] { 1, 2 },
+            new int?[] { 1, 1 }
+        );
+        yield return (
+            new int?[] { 1, 2, 3 },
+            new int?[] { 1, 0, 3 }
+        );
+    }
+}
diff --git a/...Comparers.Tests/CaseSources/NotEqualCaseSource_GetHashCode.InnerNotEqualArraysOfString.cs b/...Comparers.Tests/CaseSources/NotEqualCaseSource_GetHashCode.InnerNotEqualArraysOfString.cs
@@ -0,0 +1,47 @@
+#pragma warning disable IDE0300 // Simplify collection initialization
+
+using System.Collections.Generic;
+
+namespace PrimeFuncPack.Collections.Generic.EqualityComparers.Tests;
+
+partial class NotEqualCaseSource_GetHashCode
+{
+    private static IEnumerable<(string?[]? X, string?[]? Y)> InnerNotEqualArraysOfString()
+    {
+        yield return (
+            null,
+            EmptyArray<string>.Value);
+        yield return (
+            null,
+            new[] { "1" }
+        );
+        yield return (
+            EmptyArray<string>.Value,
+            new[] { "1" }
+        );
+        yield return (
+            new[] { "1" },
+            new[] { "1", "2" }
+        );
+        yield return (
+            new[] { "1", "2" },
+            new[] { "1", "2", "3" }
+        );
+        yield return (
+            new[] { (string?)null },
+            new[] { "1" }
+        );
+        yield return (
+            new[] { "1" },
+            new[] { "2" }
+        );
+        yield return (
+            new[] { "1", "2" },
+            new[] { "1", "1" }
+        );
+        yield return (
+            new[] { "1", "2", "3" },
+            new[] { "1", "0", "3" }
+        );
+    }
+}
diff --git a/...ources/CaseSources.InnerNotEqualArrays.cs → ...Sources/NotEqualCaseSource_GetHashCode.cs b/...ources/CaseSources.InnerNotEqualArrays.cs → ...Sources/NotEqualCaseSource_GetHashCode.cs
@@ -3,9 +3,11 @@
 
 namespace PrimeFuncPack.Collections.Generic.EqualityComparers.Tests;
 
-partial class CaseSources
+internal static partial class NotEqualCaseSource_GetHashCode
 {
-    private static IEnumerable<(T[]? X, T[]? Y)> InnerNotEqualArrays<T>()
+    // Here it is assumed a small set consisting of short arrays
+    // should lead to different hash codes with no collisions
+    internal static IEnumerable<(T[]? X, T[]? Y)> NotEqualArrays<T>()
     {
         if (typeof(T) == typeof(string))
         {

diff --git a/...qualityComparers.Tests/ImmutableArray/ImmutableArrayEqualityComparer_Nonnull_TestsBase.cs b/...qualityComparers.Tests/ImmutableArray/ImmutableArrayEqualityComparer_Nonnull_TestsBase.cs
@@ -55,15 +55,15 @@ public static void Test_Equals_InputsAreNotEqual_ExpectFalse(CaseParamOfImmutabl
 
     public static TheoryData<CaseParamOfImmutableArray<T>, CaseParamOfImmutableArray<T>> InputsAreEqualCases()
         =>
-        MapEqualsCases(CaseSources.EqualArrays<T>());
+        MapEqualsCases(EqualCaseSource.EqualArrays<T>());
 
     public static TheoryData<CaseParamOfImmutableArray<T>, CaseParamOfImmutableArray<T>> Equals_InputsAreNotEqualCases()
         =>
-        MapEqualsCases(CaseSources.Equals_NotEqualArrays<T>());
+        MapEqualsCases(NotEqualCaseSource_Equals.NotEqualArrays<T>());
 
     public static TheoryData<CaseParamOfImmutableArray<T>, CaseParamOfImmutableArray<T>> GetHashCode_InputsAreNotEqualCases()
         =>
-        MapEqualsCases(CaseSources.GetHashCode_NotEqualArrays<T>());
+        MapEqualsCases(NotEqualCaseSource_GetHashCode.NotEqualArrays<T>());
 
     private static TheoryData<CaseParamOfImmutableArray<T>, CaseParamOfImmutableArray<T>> MapEqualsCases(
         IEnumerable<(T[]? X, T[]? Y)> cases)

diff --git a/...ualityComparers.Tests/ImmutableArray/ImmutableArrayEqualityComparer_Nullable_TestsBase.cs b/...ualityComparers.Tests/ImmutableArray/ImmutableArrayEqualityComparer_Nullable_TestsBase.cs
@@ -63,15 +63,15 @@ public static void Test_Equals_InputsAreNotEqual_ExpectFalse(CaseParamOfImmutabl
 
     public static TheoryData<CaseParamOfImmutableArrayNullable<T>, CaseParamOfImmutableArrayNullable<T>> InputsAreEqualCases()
         =>
-        MapEqualsCases(CaseSources.EqualArrays<T>());
+        MapEqualsCases(EqualCaseSource.EqualArrays<T>());
 
     public static TheoryData<CaseParamOfImmutableArrayNullable<T>, CaseParamOfImmutableArrayNullable<T>> Equals_InputsAreNotEqualCases()
         =>
-        MapEqualsCases(CaseSources.Equals_NotEqualArrays<T>());
+        MapEqualsCases(NotEqualCaseSource_Equals.NotEqualArrays<T>());
 
     public static TheoryData<CaseParamOfImmutableArrayNullable<T>, CaseParamOfImmutableArrayNullable<T>> GetHashCode_InputsAreNotEqualCases()
         =>
-        MapEqualsCases(CaseSources.GetHashCode_NotEqualArrays<T>());
+        MapEqualsCases(NotEqualCaseSource_GetHashCode.NotEqualArrays<T>());
 
     private static TheoryData<CaseParamOfImmutableArrayNullable<T>, CaseParamOfImmutableArrayNullable<T>> MapEqualsCases(
         IEnumerable<(T[]? X, T[]? Y)> cases)

diff --git a/.../Collections.Generic.EqualityComparers.Tests/List/ListEqualityComparer_IList_TestsBase.cs b/.../Collections.Generic.EqualityComparers.Tests/List/ListEqualityComparer_IList_TestsBase.cs
@@ -54,15 +54,15 @@ public static void Test_Equals_InputsAreNotEqual_ExpectFalse(CaseParamOfIList<T>
 
     public static TheoryData<CaseParamOfIList<T>, CaseParamOfIList<T>> InputsAreEqualCases()
         =>
-        MapEqualsCases(CaseSources.EqualArrays<T>());
+        MapEqualsCases(EqualCaseSource.EqualArrays<T>());
 
     public static TheoryData<CaseParamOfIList<T>, CaseParamOfIList<T>> Equals_InputsAreNotEqualCases()
         =>
-        MapEqualsCases(CaseSources.Equals_NotEqualArrays<T>());
+        MapEqualsCases(NotEqualCaseSource_Equals.NotEqualArrays<T>());
 
     public static TheoryData<CaseParamOfIList<T>, CaseParamOfIList<T>> GetHashCode_InputsAreNotEqualCases()
         =>
-        MapEqualsCases(CaseSources.GetHashCode_NotEqualArrays<T>());
+        MapEqualsCases(NotEqualCaseSource_GetHashCode.NotEqualArrays<T>());
 
     private static TheoryData<CaseParamOfIList<T>, CaseParamOfIList<T>> MapEqualsCases(
         IEnumerable<(T[]? X, T[]? Y)> cases)

diff --git a/...s/Collections.Generic.EqualityComparers.Tests/List/ListEqualityComparer_List_TestsBase.cs b/...s/Collections.Generic.EqualityComparers.Tests/List/ListEqualityComparer_List_TestsBase.cs
@@ -54,15 +54,15 @@ public static void Test_Equals_InputsAreNotEqual_ExpectFalse(CaseParamOfList<T>
 
     public static TheoryData<CaseParamOfList<T>, CaseParamOfList<T>> InputsAreEqualCases()
         =>
-        MapEqualsCases(CaseSources.EqualArrays<T>());
+        MapEqualsCases(EqualCaseSource.EqualArrays<T>());
 
     public static TheoryData<CaseParamOfList<T>, CaseParamOfList<T>> Equals_InputsAreNotEqualCases()
         =>
-        MapEqualsCases(CaseSources.Equals_NotEqualArrays<T>());
+        MapEqualsCases(NotEqualCaseSource_Equals.NotEqualArrays<T>());
 
     public static TheoryData<CaseParamOfList<T>, CaseParamOfList<T>> GetHashCode_InputsAreNotEqualCases()
         =>
-        MapEqualsCases(CaseSources.GetHashCode_NotEqualArrays<T>());
+        MapEqualsCases(NotEqualCaseSource_GetHashCode.NotEqualArrays<T>());
 
     private static TheoryData<CaseParamOfList<T>, CaseParamOfList<T>> MapEqualsCases(
         IEnumerable<(T[]? X, T[]? Y)> cases)

diff --git a/...ns.Generic.EqualityComparers.Tests/ReadOnlyList/ReadOnlyListEqualityComparer_TestsBase.cs b/...ns.Generic.EqualityComparers.Tests/ReadOnlyList/ReadOnlyListEqualityComparer_TestsBase.cs
@@ -84,15 +84,15 @@ public static void Test_Equals_InputsAreNotEqual_ExpectFalse(CaseParamOfIReadOnl
 
     public static TheoryData<CaseParamOfIReadOnlyList<T>, CaseParamOfIReadOnlyList<T>> InputsAreEqualCases()
         =>
-        MapEqualsCases(CaseSources.EqualArrays<T>());
+        MapEqualsCases(EqualCaseSource.EqualArrays<T>());
 
     public static TheoryData<CaseParamOfIReadOnlyList<T>, CaseParamOfIReadOnlyList<T>> Equals_InputsAreNotEqualCases()
         =>
-        MapEqualsCases(CaseSources.Equals_NotEqualArrays<T>());
+        MapEqualsCases(NotEqualCaseSource_Equals.NotEqualArrays<T>());
 
     public static TheoryData<CaseParamOfIReadOnlyList<T>, CaseParamOfIReadOnlyList<T>> GetHashCode_InputsAreNotEqualCases()
         =>
-        MapEqualsCases(CaseSources.GetHashCode_NotEqualArrays<T>());
+        MapEqualsCases(NotEqualCaseSource_GetHashCode.NotEqualArrays<T>());
 
     private static ReadOnlyListEqualityComparer<T> BuildComparer()
         =>