solaar: move imports to top of files

lib/solaar/configuration.py

@@ -26,6 +26,7 @@
 
 import yaml as _yaml
 
+from gi.repository import GLib
 from logitech_receiver.common import NamedInt as _NamedInt
 from solaar import __version__
 
@@ -142,7 +143,6 @@ def save(defer=False):
     else:
         with save_lock:
             if not save_timer:
-                from gi.repository import GLib
                 save_timer = _Timer(5.0, lambda: GLib.idle_add(do_save))
                 save_timer.start()
 

lib/solaar/gtk.py

@@ -18,6 +18,8 @@
 ## with this program; if not, write to the Free Software Foundation, Inc.,
 ## 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
+import argparse
+import faulthandler
 import importlib
 import logging
 import os.path
@@ -26,8 +28,15 @@
 import sys
 import tempfile
 
+from traceback import format_exc
+
 import solaar.cli as _cli
+import solaar.configuration as _configuration
 import solaar.i18n as _i18n
+import solaar.listener as _listener
+import solaar.ui as _ui
+import solaar.ui.common as _common
+import solaar.upower as _upower
 
 from solaar import NAME, __version__
 
@@ -52,7 +61,6 @@ def _require(module, os_package, gi=None, gi_package=None, gi_version=None):
 
 
 def _parse_arguments():
-    import argparse
     arg_parser = argparse.ArgumentParser(
         prog=NAME.lower(), epilog='For more information see https://pwr-solaar.github.io/Solaar'
     )
@@ -122,7 +130,6 @@ def _parse_arguments():
 
 # On first SIGINT, dump threads to stderr; on second, exit
 def _handlesig(signl, stack):
-    import faulthandler
     signal.signal(signal.SIGINT, signal.SIG_DFL)
     signal.signal(signal.SIGTERM, signal.SIG_DFL)
 
@@ -161,25 +168,18 @@ def main():
         logger.warning('Solaar udev file not found in expected location')
         logger.warning('See https://pwr-solaar.github.io/Solaar/installation for more information')
     try:
-        import solaar.listener as listener
-        import solaar.ui as ui
-        import solaar.ui.common as common
-
-        listener.setup_scanner(ui.status_changed, common.error_dialog)
+        _listener.setup_scanner(_ui.status_changed, _common.error_dialog)
 
-        import solaar.upower as _upower
         if args.restart_on_wake_up:
-            _upower.watch(listener.start_all, listener.stop_all)
+            _upower.watch(_listener.start_all, _listener.stop_all)
         else:
-            _upower.watch(lambda: listener.ping_all(True))
+            _upower.watch(lambda: _listener.ping_all(True))
 
-        import solaar.configuration as _configuration
         _configuration.defer_saves = True  # allow configuration saves to be deferred
 
         # main UI event loop
-        ui.run_loop(listener.start_all, listener.stop_all, args.window != 'only', args.window != 'hide')
+        _ui.run_loop(_listener.start_all, _listener.stop_all, args.window != 'only', args.window != 'hide')
     except Exception:
-        from traceback import format_exc
         sys.exit('%s: error: %s' % (NAME.lower(), format_exc()))
 
     temp.close()

lib/solaar/i18n.py

@@ -18,6 +18,10 @@
 
 import gettext as _gettext
 import locale
+import os.path as _path
+import sys as _sys
+
+from glob import glob as _glob
 
 from solaar import NAME as _NAME
 
@@ -27,13 +31,8 @@
 
 
 def _find_locale_path(lc_domain):
-    import os.path as _path
-    import sys as _sys
     prefix_share = _path.normpath(_path.join(_path.realpath(_sys.path[0]), '..'))
     src_share = _path.normpath(_path.join(_path.realpath(_sys.path[0]), '..', 'share'))
-    del _sys
-
-    from glob import glob as _glob
 
     for location in prefix_share, src_share:
         mo_files = _glob(_path.join(location, 'locale', '*', 'LC_MESSAGES', lc_domain + '.mo'))

lib/solaar/listener.py

@@ -18,6 +18,7 @@
 
 import errno as _errno
 import logging
+import subprocess
 import time
 
 from collections import namedtuple
@@ -390,7 +391,6 @@ def _process_add(device_info, retry):
     except OSError as e:
         if e.errno == _errno.EACCES:
             try:
-                import subprocess
                 output = subprocess.check_output(['/usr/bin/getfacl', '-p', device_info.path], text=True)
                 if logger.isEnabledFor(logging.WARNING):
                     logger.warning('Missing permissions on %s\n%s.', device_info.path, output)