Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Actions workflow for Docker image CI #63

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Add GitHub Actions workflow for Docker image CI #63

wants to merge 12 commits into from

Conversation

iosefa
Copy link

@iosefa iosefa commented Jan 21, 2025

Introduce a CI workflow to build and push Docker images for pgRouting using multiple PostgreSQL, PostGIS, and pgRouting versions. Workflow triggers include pushes, pull requests, and a weekly schedule, ensuring consistent builds and updates. Docker Hub authentication and image publishing are configured for main and develop branches.

Fixes #56 and #60.

Changes proposed in this pull request:

  • add CI workflow

@pgRouting/admins

@iosefa
Add GitHub Actions workflow for Docker image CI
e17b0db 
Introduce a CI workflow to build and push Docker images for pgRouting using multiple PostgreSQL, PostGIS, and pgRouting versions. Workflow triggers include pushes, pull requests, and a weekly schedule, ensuring consistent builds and updates. Docker Hub authentication and image publishing are configured for main and develop branches.
@iosefa iosefa self-assigned this Jan 21, 2025
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

This was referenced Jan 21, 2025
Open
Open
@sanak
Copy link
Member

sanak commented Jan 23, 2025

@iosefa Thanks for creating this PR!
If possible, supporting the followings are more useful, I think.

  1. Support pgRouting patch version (3.7.x, etc.) tag
  2. Push docker images only when patch version update or commit hash update in pgRouting main and develop

I want to try the above 2 things on my side, but are you okay with that ?

@iosefa
Copy link
Author

iosefa commented Jan 23, 2025

@iosefa Thanks for creating this PR! If possible, supporting the followings are more useful, I think.

  1. Support pgRouting patch version (3.7.x, etc.) tag

  2. Push docker images only when patch version update or commit hash update in pgRouting main and develop

I want to try the above 2 things on my side, but are you okay with that ?

@sanak sure! if you want to add those two things and work from here, that is fine with me. Thank you!

@sanak
Copy link
Member

sanak commented Jan 24, 2025

@sanak sure! if you want to add those two things and work from here, that is fine with me. Thank you!

Thanks for confirmation!
I will be a bit busy until 1/31(Fri), so it may take until 2/3(Mon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@iosefa iosefa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish newest images to dockerhub
2 participants
@iosefa @sanak