Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions workflow for Docker image CI #63

Merged
merged 32 commits into from
Feb 11, 2025

Conversation

iosefa
Copy link
Contributor

@iosefa iosefa commented Jan 21, 2025

Introduce a CI workflow to build and push Docker images for pgRouting using multiple PostgreSQL, PostGIS, and pgRouting versions. Workflow triggers include pushes, pull requests, and a weekly schedule, ensuring consistent builds and updates. Docker Hub authentication and image publishing are configured for main and develop branches.

Fixes #56 and #60.

Changes proposed in this pull request:

  • add CI workflow

@pgRouting/admins

Introduce a CI workflow to build and push Docker images for pgRouting using multiple PostgreSQL, PostGIS, and pgRouting versions. Workflow triggers include pushes, pull requests, and a weekly schedule, ensuring consistent builds and updates. Docker Hub authentication and image publishing are configured for main and develop branches.
@iosefa iosefa self-assigned this Jan 21, 2025

This comment was marked as outdated.

@sanak
Copy link
Member

sanak commented Jan 23, 2025

@iosefa Thanks for creating this PR!
If possible, supporting the followings are more useful, I think.

  1. Support pgRouting patch version (3.7.x, etc.) tag
  2. Push docker images only when patch version update or commit hash update in pgRouting main and develop

I want to try the above 2 things on my side, but are you okay with that ?

@iosefa
Copy link
Contributor Author

iosefa commented Jan 23, 2025

@iosefa Thanks for creating this PR! If possible, supporting the followings are more useful, I think.

  1. Support pgRouting patch version (3.7.x, etc.) tag

  2. Push docker images only when patch version update or commit hash update in pgRouting main and develop

I want to try the above 2 things on my side, but are you okay with that ?

@sanak sure! if you want to add those two things and work from here, that is fine with me. Thank you!

@sanak
Copy link
Member

sanak commented Jan 24, 2025

@sanak sure! if you want to add those two things and work from here, that is fine with me. Thank you!

Thanks for confirmation!
I will be a bit busy until 1/31(Fri), so it may take until 2/3(Mon).

@sanak
Copy link
Member

sanak commented Feb 11, 2025

Hi @pgRouting/admins, @krashish8, @iosefa (CC: @smellman)
This PR is ready for merge, so reviewing diffs (especially, .github/workflows/main.yml and Makefile) is helpful. 🙇

Changes proposed in this pull request:

About DockerHub image push, I confirmed it on my account without extra image with the following diff.

The followings are a bit challenging, so I am planning to do those with another PRs.

@sanak sanak assigned sanak and unassigned iosefa Feb 11, 2025
@sanak sanak marked this pull request as ready for review February 11, 2025 01:46
@robe2 robe2 merged commit 0434344 into master Feb 11, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish newest images to dockerhub
3 participants