Allow adding and connecting the server using pgbouncer database aliases.#3564 #8485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogeshmahajan-1903
force-pushed
the
GH_3564
branch
from
97a8123 to
b51c445
Compare
adityatoshniwal
requested changes
Feb 24, 2025
|
|
||
|
|
||
| def upgrade(): | ||
| op.add_column('server', sa.Column('db_alias', sa.String(length=256))) |
There was a problem hiding this comment.
when adding new column to server always add autoincrement
with op.batch_alter_table(
"server", table_kwargs={'sqlite_autoincrement': True}) as batch_op:
batch_op.add_column(sa.Column('tags', sa.JSON(), nullable=True))
| @@ -767,6 +768,7 @@ def update(self, gid, sid): | |||
| 'name': gettext('name'), | |||
| 'port': gettext('Port'), | |||
| 'db': gettext('Maintenance database'), | |||
| 'db_alias': gettext('Database Alias '), | |||
There was a problem hiding this comment.
remove leading space.
| mode: ['properties', 'edit', 'create'], readonly: obj.isConnected, | ||
| disabled: function(state) { | ||
| return !isEmptyString(state.db); | ||
| }, |
There was a problem hiding this comment.
We should add help message here - This is helpful in pg_bouncer where server can be connected using database alias name
yogeshmahajan-1903
force-pushed
the
GH_3564
branch
from
7641925 to
294e822
Compare
|
As per discussion with Dave, this PR is not required anymore, hence closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.