Avoid using h5 in dt context for eventlist #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't look right to me. You're creating a |
The h5 element is not allowed as a descendant of a dt element as dl is defined as flow content whereas hX is phrasing content. Fix by decorating the dt element with the styling that h5 provided.
danielgustafsson
force-pushed
the
dg-eventlist
branch
from
f3b92d5 to
7734b20
Compare
|
Agreed, I've pushed a rebased version doing this which seems a better option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The h5 element is not allowed as a descendant of a dt element as dl is defined as flow content whereas hX is phrasing content. Fix by replacing with a span and CSS to match the styling that the h5 element provided.
Also fix three-space indentation while in there.