firmata#136: Allow sysex messages to have the maximum size

The START_SYEX and END_SYSEX bytes do not count
pgrawehr · May 13, 2023 · 906165e · 906165e
1 parent 1b78649
commit 906165e
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/src/ConfigurableFirmata.cpp b/src/ConfigurableFirmata.cpp
@@ -325,15 +325,17 @@ void FirmataClass::parse(byte inputData)
       //fire off handler function
       processSysexMessage();
     } else {
-      //normal data byte - add to buffer
-      storedInputData[sysexBytesRead] = inputData;
-      sysexBytesRead++;
-	  if (sysexBytesRead == MAX_DATA_BYTES)
-	  {
-		  Firmata.sendString(F("Discarding input message, out of buffer"));
-		  parsingSysex = false;
-		  sysexBytesRead = 0;
-		  waitForData = 0;
+      if (sysexBytesRead == MAX_DATA_BYTES)
+      {
+          Firmata.sendString(F("Discarding input message, out of buffer"));
+          parsingSysex = false;
+          sysexBytesRead = 0;
+          waitForData = 0;
+      }
+      else {
+          // normal data byte - add to buffer (done after the above, so sysex messages can actually have a total length of MAX_DATA_BYTES + 2
+          storedInputData[sysexBytesRead] = inputData;
+          sysexBytesRead++;
       }
 	}
   } else if ( (waitForData > 0) && (inputData < 128) ) {