Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add context to get approval request #14

Merged
merged 6 commits into from
Nov 5, 2024

Conversation

edwinkys
Copy link
Contributor

@edwinkys edwinkys commented Nov 5, 2024

Description

Fixes #1

This PR allows clients to pass context string to the server which then will be relayed to the dashboard. This allows approvers to have a better context about the pending operation. This could be used to pass comments about the function or LLM prompts triggering the function, etc.

How Has This Been Tested?

I'm not quite sure how to add a unit test to include this change.

Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.

@edwinkys edwinkys added the enhancement New feature or request label Nov 5, 2024
@edwinkys edwinkys self-assigned this Nov 5, 2024
@edwinkys edwinkys linked an issue Nov 5, 2024 that may be closed by this pull request
@edwinkys edwinkys merged commit 0abd20e into main Nov 5, 2024
2 checks passed
@edwinkys edwinkys deleted the 1-add-context-to-get-approval-request branch November 5, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] add context to get approval request
1 participant