Add extension .phar to installed tools #439
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's actually very much intentional we drop the extension. And one of the reaons is exactly that PHPStorm does NOT "see" them. Because you exactly do NOT want to have autocomplete for code that just happens to be used by your tools. I see that there is at least one valid edge case: PHPUnit, which happens to be a tool as well as a framework for which you'd want autocomplete when writing tests. But then again, you do NOT want auto complete for all of PHPUnit but only the relevant framework components. Thanks for providing this PR though anyway. I have to think about this change. It feels like the wrong solution to the problem. |
|
On my point of view, it is useful not only for PHPUnit, but for all scripts which works with configs in php-files. |
Aeliot-Tm
force-pushed
the
add-exteension-to-installed-tools
branch
from
1a20241
to
f8b1ab5
Compare
Aeliot-Tm
force-pushed
the
add-exteension-to-installed-tools
branch
from
f8b1ab5
to
7ce133c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPStorm don't understand content of PHAR file and cannot autocomplete when tool installed via link and without extension. Currently, we have to do it manually. So, this update should help to solve this issue.