Fix #writeExtensionMethods:className: on TonelWriter to sort methods with the same selector consistently #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with the same selector consistently (putting the metaclass’s method first).
|
Thank you!! I had on my todo list a item to fix this since months :) I often had the problem with Epicea but I never found the time to check the origin of the problem. |
jecisc
approved these changes
Apr 21, 2024
|
I just noticed there’s an issue about this as well: issue #65. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes
#writeExtensionMethods:className:on TonelWriter to sort methods with the same selector consistently (putting the metaclass’s method first). This avoids the confusing reordering of, for example, the#taskbarIconNamemethods in ‘Object.extension.st’ in ‘Morphic-Base’ like in Pharo commits 56e2288f4b, cad205a6a3, 206ca1db95, 3b669bacaa and c403ecc570. The snippet given in Pharo pull request #14743 could be used to rewrite all ‘.extension.st’ files but that may cause merge conflicts in some open pull requests.