Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded version of boto3 #1310

Merged
merged 1 commit into from
Oct 14, 2024
Merged

upgraded version of boto3 #1310

merged 1 commit into from
Oct 14, 2024

Conversation

phenobarbital
Copy link
Owner

@phenobarbital phenobarbital commented Oct 14, 2024

Summary by Sourcery

Upgrade the boto3-related dependencies to newer versions and update the library version to 2.9.3.

Enhancements:

  • Update the version of aiobotocore and aioboto3 dependencies to improve compatibility and performance.

Chores:

  • Bump the version of the asyncdb library from 2.9.2 to 2.9.3.

Copy link
Contributor

sourcery-ai bot commented Oct 14, 2024

Reviewer's Guide by Sourcery

This pull request upgrades the version of boto3 and related dependencies, updates the cryptography package requirement, and makes minor changes to the BigQuery driver and version number.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Upgrade boto3 and related dependencies
  • Remove botocore dependency
  • Upgrade aiobotocore to version 2.15.2 with boto3 extra
  • Upgrade aioboto3 to version 13.2.0
setup.py
Update cryptography package requirement
  • Change cryptography requirement from '==43.0.1' to '>=43.0.1'
setup.py
Minor documentation update in BigQuery driver
  • Add a period at the end of the docstring for the write method
asyncdb/drivers/bigquery.py
Bump package version
  • Increase version number from 2.9.2 to 2.9.3
asyncdb/version.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@phenobarbital phenobarbital merged commit 5e7ee6f into master Oct 14, 2024
1 of 2 checks passed
@phenobarbital phenobarbital deleted the new-drivers branch October 14, 2024 23:06
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @phenobarbital - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using a more specific version range for cryptography (e.g., '>=43.0.1,<44') instead of '>=43.0.1' to prevent potential future compatibility issues while still allowing for minor updates.
  • Given the significant updates to boto3-related packages, consider whether a minor version bump (e.g., to 2.10.0) might be more appropriate than the current patch version increase.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟡 Security: 1 issue found
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -110,7 +110,7 @@ def readme():
"wheel==0.44.0"
],
install_requires=[
"cryptography==43.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 suggestion (security): Consider adding an upper bound to the cryptography version range

While using a minimum version ensures getting security updates, it might lead to unexpected behavior if a major version bump occurs. Consider adding an upper bound or explaining the rationale for using only a minimum version.

    install_requires=[
        "cryptography>=43.0.1,<44.0.0",
        "aiohttp>=3.9.5",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant