-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgraded version of boto3 #1310
Conversation
Reviewer's Guide by SourceryThis pull request upgrades the version of boto3 and related dependencies, updates the cryptography package requirement, and makes minor changes to the BigQuery driver and version number. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @phenobarbital - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a more specific version range for cryptography (e.g., '>=43.0.1,<44') instead of '>=43.0.1' to prevent potential future compatibility issues while still allowing for minor updates.
- Given the significant updates to boto3-related packages, consider whether a minor version bump (e.g., to 2.10.0) might be more appropriate than the current patch version increase.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -110,7 +110,7 @@ def readme(): | |||
"wheel==0.44.0" | |||
], | |||
install_requires=[ | |||
"cryptography==43.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 suggestion (security): Consider adding an upper bound to the cryptography version range
While using a minimum version ensures getting security updates, it might lead to unexpected behavior if a major version bump occurs. Consider adding an upper bound or explaining the rationale for using only a minimum version.
install_requires=[
"cryptography>=43.0.1,<44.0.0",
"aiohttp>=3.9.5",
Summary by Sourcery
Upgrade the boto3-related dependencies to newer versions and update the library version to 2.9.3.
Enhancements:
Chores: