Delete the refresh token at the end

philip-gai · Apr 4, 2022 · d1df659 · d1df659
1 parent 90973c0
commit d1df659
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/web-app/src/eventHandlers/pullRequestEventHandler.ts b/web-app/src/eventHandlers/pullRequestEventHandler.ts
@@ -229,16 +229,15 @@ Please fix the issues and recreate a new PR:
         } catch (err) {
           const errorMessage = HelperService.getErrorMessage(err);
           logger.error(errorMessage);
-        } finally {
-          // Delete the token to avoid conflicts with prod
-          const appId = this._configService.appConfig.appId;
-          if (appId !== ConfigService.prodAppId) {
-            logger.info(`Current app (${appId}) is not prod, deleting ${authorLogin}'s refresh token`);
-            this._tokenService.deleteRefreshToken(authorLogin);
-          }
         }
       }
     }
+    // Delete the token to avoid conflicts with prod
+    const appId = this._configService.appConfig.appId;
+    if (appId !== ConfigService.prodAppId) {
+      logger.info(`Current app (${appId}) is not prod, deleting ${authorLogin}'s refresh token`);
+      await this._tokenService.deleteRefreshToken(authorLogin);
+    }
     logger.info("Exiting pull_request.closed handler");
   };