eliminate use of extract(). Fixes #8.

phillord · Feb 26, 2015 · 4dacc90 · 4dacc90
1 parent 44656c8
commit 4dacc90
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/mathjax-latex.php b/mathjax-latex.php
@@ -152,10 +152,11 @@ public static function latex_shortcode( $atts, $content ) {
 		self::$add_script = true;
 
 		// this gives us an optional "syntax" attribute, which defaults to "inline", but can also be "display"
-		extract( shortcode_atts( array( 'syntax' => get_option( 'kblog_mathjax_latex_inline' ) ), $atts ) );
-		if ( 'inline' === $syntax ) {
+		$shortcode_atts = shortcode_atts( array( 'syntax' => get_option( 'kblog_mathjax_latex_inline' ) ), $atts );
+
+		if ( 'inline' === $shortcode_atts['syntax'] ) {
 			return '\(' . $content . '\)';
-		} else if ( 'display' === $syntax ) {
+		} else if ( 'display' === $shortcode_atts['syntax'] ) {
 			return '\[' . $content . '\]';
 		}
 	}