Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Node.js to version 21 #54

Merged
merged 3 commits into from
Jan 21, 2024
Merged

Upgrade Node.js to version 21 #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
602479e
Fixed typo in CONTRIBUTING.md
phjardas Jan 21, 2024
ba2db3f
Upgrade Node.js to version 21
phjardas Jan 21, 2024
ecf51fe
fix ci
phjardas Jan 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/moody-papayas-learn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"taktische-zeichen-cli": minor
"taktische-zeichen-core": minor
"taktische-zeichen-react": minor
"taktische-zeichen-web-component": minor
"taktische-zeichen-website": minor
---

Upgrade Node.js version to 21
14 changes: 5 additions & 9 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,28 +8,24 @@ on:
pull_request:
branches:
- main
types: [assigned]
types:
- assigned

jobs:
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Setup Node.js
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
# keep in sync with package.json/volta
node-version: 16.13.2
node-version-file: package.json
cache: npm
cache-dependency-path: |
package-lock.json
packages/*/package-lock.json

- name: Install npm
# keep in sync with package.json/volta
run: npm i -g [email protected]

- run: npm ci
- run: npm run bootstrap

Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ Vielen Dank, dass du an der Entwicklung der Taktischen Zeichen mitarbeiten möch

## Voraussetzungen

Du benötigst [Node 16](https://nodejs.org/en/download/). Fertig. Wir empfehlen [Volta](https://volta.sh/).
Du benötigst [Node 21](https://nodejs.org/en/download/). Fertig. Wir empfehlen [Volta](https://volta.sh/).

## Installation

```bash
npm ci
npm bootstrap
npm run bootstrap
```

## Bauen
Expand Down
56 changes: 28 additions & 28 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
"nodemon": "^2.0.15"
},
"volta": {
"node": "16.13.2",
"npm": "8.3.0"
"node": "21.6.0"
}
}
3 changes: 1 addition & 2 deletions packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
"shx": "^0.3.4"
},
"volta": {
"node": "16.13.2",
"npm": "8.3.0"
"node": "21.6.0"
}
}
106 changes: 30 additions & 76 deletions packages/core/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
},
"devDependencies": {
"@types/jest": "^27.4.0",
"@types/node": "^17.0.8",
"@types/node": "^20.11.5",
"jest": "^27.4.7",
"prettier": "^2.5.1",
"shx": "^0.3.4",
Expand All @@ -43,7 +43,6 @@
"typescript": "^4.5.4"
},
"volta": {
"node": "16.13.2",
"npm": "8.3.0"
"node": "21.6.0"
}
}
Loading