-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Additional files not regonized #244
base: main
Are you sure you want to change the base?
Conversation
edc3a3e
to
145248c
Compare
145248c
to
3d8f61a
Compare
3d8f61a
to
f9d4517
Compare
f9d4517
to
ce105e1
Compare
@phmonte with a nice |
37f4356
to
4d856cb
Compare
I think I found the problem, you can see it in my commit. |
I've been working on a new way of tracing/logging, that also is really in draft mode, but I think it looks promising. I've created another (draft) pr for that: #286 |
Perfect, I made a small change to the test project, keeping only 1 TargetFrameworks field and removing the TargetFramework, looking at the documentation here . I believe the additional files worked and the test passed. I noticed that the MessageRaised event is called according to the number of TargetFramework(s), when placing the 2 fields, it considered only the first one, as it says in the documentation |
@phmonte It defined wrong on purpose. ;) It is part of a test for .NET project file analyzers. I was suspecting that it might not work because of this. Sorry, I should have specified that. |
As mentioned in #243, I noticed that in some projects additional files (and other properties as well I guess, but that was not what I was investigating) are not recognized.
I've added created this PR, that adds a replay where the additional files are not available in the
AnalyzerResult
.EventProcessor.MessageRaised(object sender, BuildMessageEventArgs e)
is triggered only for v6.0.I'll update mine findings here.
For some background, I use Buildalyzer to test Roslyn Analyzers that check for issues in .NET project files, such as MS Build project files, and RESX files. Access to the additional files is the perquisite for those tests to work. See: dotnet-project-file-analyzers