-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Load Balancer Functionality #239
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @crazyboycjr |
crazyboycjr
requested changes
Sep 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to merge mrpclb and mrpc. Maybe need some refactoring work on removing cmd_tx/cmd_rx
first.
Can you merge this first? I feel like the refactor and message bus requires a lot of code change, and perhaps we should separate it from load balancer. |
crazyboycjr
pushed a commit
that referenced
this pull request
Oct 25, 2023
crazyboycjr
pushed a commit
that referenced
this pull request
Dec 4, 2023
* test live update * update * update make file * remove rdma * update phoenix * update ratelimt drop * Basic Load Balancer Functionality (#239) * example * backup mrpc engine * template for lb * try * remove addon * connected control path, in a ad hoc way * update * it works 😃 * finish connect * it worked🥵 * refactor * work work * refactor * fix * fix trivial * admission control * finish admisson control * metrics * mutation * update * fix version * server side engines * add server side impls * scripts * update * fix scripts * fix * update ratelimit * update cargo --------- Co-authored-by: banruo <banruo@localhost>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Now we support client connect to multiple server ip address and a basic round-robin load balancer that distribute the request accordingly.
Changes
Todos
Checks
scripts/clippy.sh
to lint the changes in this PR.